[Ffmpeg-devel] [PATCH] ffserver warning cleanup

[Benjamin Larsson]

Bryan Mayland wrote:

> This patch cleans up all the compile warnings about signed/unsigned
> buffer pointers in ffserver.c. gcc version 4.0.2 20050808 (prerelease)
> (Ubuntu 4.0.1-4ubuntu9)
>
> I also added a feed_child_argv_free() method to free the memory
> allocated for the feed child_argv parameters.  Since ffserver never
> really cleanly exits it isn't used except when the child process is
> exiting quickly.  I can attach a signal handler so the http_server()
> function exits if requested, but I didn't want to do too much in this
> patch.
> Just a little clean up.
>
>------------------------------------------------------------------------
>
>
>@@ -4251,7 +4259,7 @@
>             }
> 
>             if (!errors) {
>-                IPAddressACL *nacl = (IPAddressACL *) av_mallocz(sizeof(*nacl));
>+                IPAddressACL *nacl = (IPAddressACL *)av_mallocz(sizeof(*nacl));
>  
>
Cosmetics.

>                 IPAddressACL **naclp = 0;
> 
>                 *nacl = acl;
>
>  
>
The rest look ok to me.

MvH
Benjamin Larsson

-- 
"incorrect information" is an oxymoron. Information is, by definition, factual, correct.