[Ffmpeg-devel] x264 global headers?

[Måns Rullgård]

M?ns Rullg?rd <mru at inprovide.com> writes:

> Luca Abeni <lucabe72 at email.it> writes:
>
>> Hi M?ns,
>>
>> On Thu, 2006-01-19 at 23:43 +0000, M?ns Rullg?rd wrote:
>> [...]
>>> I'd prefer the attached patch as it allocates a more reasonable amount
>>> of memory for the headers.  I'm not sure how to test it, so I won't
>>> commit until someone has confirmed that it works.
>> I just tried it, and it works for me. The application is not
>> segfaulting, so I assume the FF_INPUT_BUFFER_PADDING_SIZE padding I
>> mentioned this morning should not be a problem (but I have no valgrind
>> or any memory debugger installed). The content in "extradata" allows me
>> to create a valid "sprop-parameter-sets" (at least, mpeg4ip likes it),
>> so I assume it is correct.
>
> The buffer padding is only needed when the data will be read by the
> bitstream reader.  That is not the case here, since we are encoding.

Forgot to say I commited the change.

-- 
M?ns Rullg?rd
mru at inprovide.com