[Ffmpeg-devel] [PATCH] from DivX, Part 6: clean types

[Michael Niedermayer]

Hi

On Fri, Dec 16, 2005 at 12:25:47PM -1000, Steve Lhomme wrote:
> Mostly to avoid compiler warnings, and also make it better for 64 bits 
> compilers.
> 
> The patch in matroska also renames the variable because apparently it 
> didn't like that one. (probably a #define to something else in the 
> system includes)

[...]
>  #ifdef MEMALIGN_HACK
>      int diff;
> +    char *_ptr = ptr;

umm, this is ugly


[...]
>  static int asf_write_index(AVFormatContext *s, ASFIndex *index, uint16_t max, uint32_t count)
>  {
>      ByteIOContext *pb = &s->pb;
> -    int i;
> +    uint32_t i;

ugly too

[...]

>  typedef struct AVIIentry {
> -    unsigned int flags, pos, len;
> +    unsigned int flags;
> +    offset_t pos;
> +    unsigned int len;
>  } AVIIentry;

this is not correct


[...]

> -void put_le32(ByteIOContext *s, unsigned int val);
> -void put_be32(ByteIOContext *s, unsigned int val);
> -void put_be24(ByteIOContext *s, unsigned int val);
> -void put_le16(ByteIOContext *s, unsigned int val);
> -void put_be16(ByteIOContext *s, unsigned int val);
> +void put_le32(ByteIOContext *s, uint32_t val);
> +void put_be32(ByteIOContext *s, uint32_t val);
> +void put_be24(ByteIOContext *s, uint32_t val);
> +void put_le16(ByteIOContext *s, uint16_t val);
> +void put_be16(ByteIOContext *s, uint16_t val);

why?!

[...]

-- 
Michael