[Ffmpeg-devel] PATCH: make libavformat find codecid for AAC streams in matroska container.

[Michael Niedermayer]

Hi

On Fri, Jan 27, 2006 at 09:15:59AM -1000, Steve Lhomme wrote:
> elupus wrote:
> >Hi, 
> >
> >Here is a small patch to allow libavformat to find the codec on AAC streams
> >in matroska containers. 
> >
> >The defines for the AAC codec's are set like this, 
> >
> >	#define MATROSKA_CODEC_ID_AUDIO_MPEG2        "A_AAC/MPEG2/"
> >	#define MATROSKA_CODEC_ID_AUDIO_MPEG4        "A_AAC/MPEG4/"
> >
> >which isn't the full name for the codec's. I.e. it normally has some more
> >extension to it like MAIN, LC... 
> >
> >Anyway, this patch fixes so that when the codec_id is compared to these
> >defines, only the given length is compared (which I think was the original
> >idea). I suppose some more information could be gotten from that extra
> >information, but I think this should be enough.
> >
> >Cheers
> >
> >/Joakim
> 
> I provided a patch that handles this and the codec private and also the 
> new and simple A_AAC (everything is said in the codec private). But the 
> patch was rejected (although factorizing that code means having FAAD 
> support which is GPL).

faad != libavcodec/faad.c(LGPL)

egrep '(88200|General Public License)' `grep -l ' 88200' {,*/,*/*/}*.{c,h}`
libavcodec/faad.c: * Lesser General Public License for more details.
libavcodec/faad.c:    96000, 88200, 64000, 48000, 44100, 32000,
libavformat/mov.c: * Lesser General Public License for more details.
libavformat/mov.c:                     96000, 88200, 64000, 48000, 44100, 32000,

[...]
-- 
Michael