[Ffmpeg-devel] [PATCH] Check for __PIC__ beside PIC to enable PIC-safe code

[Måns Rullgård]

Diego 'Flameeyes' Petten? <flameeyes at gentoo.org> writes:

> Okay, if defining __PIC__ isn't acceptable, this patch checks for
> both PIC and __PIC__ when entering the section that needs to be
> PIC-safe.  The reason for pushing the change in the source files
> rather than in the build system is simply to not require mangling of
> the sources when imported in other projects (xine-lib, xdtv).
> That's why checking inside the configure for __PIC__ presence and
> then defining PIC isn't going to help.

1. Why can't those other projects just be civilized and use the ffmpeg
build system, inside or outside their source tree?

2. Wouldn't

#ifdef __PIC__
#define PIC
#endif

in some suitable header be nicer?

-- 
M?ns Rullg?rd
mru at inprovide.com