[Ffmpeg-devel] [PATCH] Chinese AVS video decoder

[Michael Niedermayer]

Hi

On Sat, Jul 01, 2006 at 01:05:44PM +0200, Stefan Gehrer wrote:
> second try of a patch, following points addressed:
[...]
> - create new file cavsdsp.c for DSP functions. In consequence, there is
>   also a header file for the prototypes and some put/avg_pixels8/16
>   functions in dsputil.c are made non-static. Is this acceptable?

yes but their names need to be chaged to avoid possible name clashes
a ff_ prefix should be added ...


[...]

the intra prediction code, or more precissely the border loading stuff
is a little messy, first things are stored in left/top_border* then they
are copied to top/left and then they are finaly used, can that 2 level
copy be avoided and pointers to left/top_border* be passed into the
intra prediction functions?

ive added the new files to svn, ill commit the rest of your patch as soon
as you add a ff_ prefix (or av*_ for anything which should be vissible to 
the user application) to the new non static functions

also if you want to maintain the AVS decoder and want a svn account, just
send a password and username to diego (and read the development docs &
policy)

!!! and dont send any valuable password, svn stores passwords in plaintext
on the server and authenticates the developers so that a passive listener
can do a dictionary attack ...

btw, diego, do you have a gpg key? might be usefull if people send you
passwords and such ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is