[Ffmpeg-devel] [PATCH] [RFC] makefile cleanup

[Diego Biurrun]

On Sat, Jul 08, 2006 at 01:11:06AM +0100, M?ns Rullg?rd wrote:
> Here's a patch that slashes a massive 202 lines (of 486) from the lavc
> makefile.  In my opinion it's more readable this way.  Comments?

[..]
> +OBJS-$(CONFIG_MMVIDEO_DECODER) += mmvideo.o
> +OBJS-$(CONFIG_ZMBV_DECODER) += zmbv.o
> +OBJS-$(CONFIG_FLASHSV_DECODER) += flashsv.o

Well, while you're at it you could prettyprint this and align the +=.
No, it's not important...

>  # sun mediaLib specific stuff
> -# currently only works when libavcodec is used in mplayer
> -ifeq ($(HAVE_MLIB),yes)
> -OBJS += mlib/dsputil_mlib.o
> -CFLAGS += $(MLIB_INC)
> -endif
> +OBJS-$(HAVE_MLIB) += mlib/dsputil_mlib.o
>  
> -# Intel IPP specific stuff
> -# currently only works when libavcodec is used in mplayer
> -ifeq ($(HAVE_IPP),yes)
> -CFLAGS += $(IPP_INC)
> -endif

This is not an equivalent change.  We can discuss removing this, but it
should not be part of this cleanup patch.

Diego