[Ffmpeg-devel] [PATCH] [RFC] makefile cleanup

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Sat, Jul 08, 2006 at 04:59:55PM +0100, M?ns Rullg?rd wrote:
>> Diego Biurrun <diego at biurrun.de> writes:
>> 
>> > On Sat, Jul 08, 2006 at 01:11:06AM +0100, M?ns Rullg?rd wrote:
>> >> Here's a patch that slashes a massive 202 lines (of 486) from the lavc
>> >> makefile.  In my opinion it's more readable this way.  Comments?
>> >
>> >>  # sun mediaLib specific stuff
>> >> -# currently only works when libavcodec is used in mplayer
>> >> -ifeq ($(HAVE_MLIB),yes)
>> >> -OBJS += mlib/dsputil_mlib.o
>> >> -CFLAGS += $(MLIB_INC)
>> >> -endif
>> >> +OBJS-$(HAVE_MLIB) += mlib/dsputil_mlib.o
>> >>  
>> >> -# Intel IPP specific stuff
>> >> -# currently only works when libavcodec is used in mplayer
>> >> -ifeq ($(HAVE_IPP),yes)
>> >> -CFLAGS += $(IPP_INC)
>> >> -endif
>> >
>> > This is not an equivalent change.  We can discuss removing this, but it
>> > should not be part of this cleanup patch.
>> 
>> OK, here's a new patch.
>> 
>> --- Makefile	(revision 5670)
>> +++ Makefile	(working copy)
>> @@ -23,336 +23,172 @@
>>  
>>  [...]
>>  
>> +OBJS-$(CONFIG_AC3)$(CONFIG_A52BIN)     += liba52/bit_allocate.o	\
>> +                                          liba52/bitstream.o	\
>> +                                          liba52/downmix.o	\
>> +                                          liba52/imdct.o	\
>> +                                          liba52/parse.o	\
>> +                                          liba52/crc.o		\
>> +                                          liba52/resample.o
>
> Here and in other places, please align the backslashes, that makes it
> look so much neater :)  Yes, I'm nitpicking, then again I know you are
> not averse to this...

Darned emacs backslashify used evil tabs...

>>  # sun mediaLib specific stuff
>> -# currently only works when libavcodec is used in mplayer
>
> Leave this comment line, it will serve as a friendly reminder..

But it's not true.  It works perfectly well stand-alone, at least on
the Sun box I have access to.

-- 
M?ns Rullg?rd
mru at inprovide.com