[Ffmpeg-devel] [patch] building on windows

[Diego Biurrun]

On Thu, Jul 13, 2006 at 08:27:16PM -0300, Ramiro Polla wrote:
> Diego Biurrun wrote:
> >On Fri, Jul 14, 2006 at 01:03:30AM  0200, Herv? W. wrote:
> >
> >>On 14/07/06, Diego Biurrun <diego at biurrun.de> wrote:
> >>
> >>>On Thu, Jul 13, 2006 at 04:40:45PM  0200, Christoph Pfister wrote:
> >>>
> >>>>The following rule in the makefile doesn't work properly because 
> >>>>symlinks
> >>>>aren't available on windows.
> >>>>
> >>>>Because of that users have to manually rename e.g. avcodec.dll.<number> 
> >>>>to avcodec.dll. The following patch fixes it.
> >>>>
> >>>>--- old/common.mak    2006-07-13 16:17:56.000000000  0200
> >>>>    new/common.mak    2006-07-13 16:32:07.000000000  0200
> >>>>@@ -18,7  18,11 @@ $(LIB): $(STATIC_OBJS)
> >>>>      $(RANLIB) $@
> >>>>
> >>>> $(SLIBNAME): $(SLIBNAME_WITH_MAJOR)
> >>>> ifeq ($(CONFIG_MINGW),yes)
> >>>>      cp -sf $^ $@
> >>>> else
> >>>>      ln -sf $^ $@
> >>>> endif
> >>>>
> >>>Hmm, 'cp -sf' makes symbolic links as well, at least with GNU cp.  So
> >>>does this work properly on Windows?  The '-s' gets ignored or what?
> >>>
> >>At least in MSYS version 1.0.10   'ln -s' and 'cp -s'  already make
> >>copies of the files that are supposed to be linked to. I'm not sure in
> >>which situation Christophs patch is relevant.
> >
> >So MinGW/MSYS has ln?  Then this patch is unnecessary.
> >
> Yes, this patch is unecessary. MSYS has ln, and does exactly what the
> patch suggests. The ln command actually makes a copy, just like cp would.

So it's patch rejected, case closed.

Diego