[Ffmpeg-devel] [PATCH] Cygwin vhook, always static avformat

[Måns Rullgård]

Diego Biurrun said:
> On Fri, Jul 14, 2006 at 01:58:29PM +0200, V?ctor Paesa wrote:
>>
>> >>> --- ffmpeg-old/vhook/Makefile	2006-07-12 17:55:48.000000000 +0200
>> >>> +++ ffmpeg/vhook/Makefile	2006-07-13 18:07:12.968750000 +0200
>> >>> @@ -5,6 +5,13 @@
>> >>>  CFLAGS=-fPIC $(SHCFLAGS) -I.. -I$(SRC_PATH) -I$(SRC_PATH)/libavformat
>> >>> \
>> >>>         -I$(SRC_PATH)/libavcodec -I$(SRC_PATH)/libavutil
>> >>> -DHAVE_AV_CONFIG_H
>> >>>
>> >>> +ifeq ($(TARGET_OS),CYGWIN)
>> >>> +    EXTRALIBS := -Wl,--no-whole-archive \
>> >>> +                 -L../libavformat -lavformat$(BUILDSUF) \
>> >>> +                 -L../libavcodec  -lavcodec$(BUILDSUF)  \
>> >>> +                 -L../libavutil   -lavutil$(BUILDSUF) $(EXTRALIBS)
>> >>> +endif
>> >>> +
>> >>>  #FIXME: This needs to be in configure/config.mak
>> >>>  ifeq ($(CONFIG_DARWIN),yes)
>> >>>  	SHFLAGS = -dynamiclib -Wl,-single_module -flat_namespace \
>> >>
>> >> This is hackish, then again, we already have this other FIXME for Darwin
>> >> there.  The vhook build needs to be overhauled, but this is not
>> >> necessarily for you to solve..
>> >
>> > I'd tend to agree there.
>> >
>> Uff, too subtle English for me, will you take care of de-hackering this or
>> not?
>
> It means that because the vhook Makefile is hackish to begin with (and
> this is not your fault) we are willing to accept a hackish solution here
> that we would reject in other places...

I'd prefer that we first got rid of the hacks, then fixed it properly for
cygwin (if we must).

-- 
M?ns Rullg?rd
mru at inprovide.com