[Ffmpeg-devel] [RFC] move stuff in libavutil/common.h out of #ifdef HAVE_AV_CONFIG_H

[Michael Niedermayer]

Hi

On Sat, Jul 15, 2006 at 02:29:01PM +0200, Reimar D?ffinger wrote:
> Hello,
> On Sun, Jul 09, 2006 at 12:49:52PM +0200, Michael Niedermayer wrote:
> > On Sun, Jul 09, 2006 at 11:41:08AM +0200, Reimar D?ffinger wrote:
> [...]
> > i think the semantics are mostly internal vs. external availability
> > -> i think common.h should be split ...
> [...]
> > iam fine with the patch except that
> > FASTDIV / inverse   (not even documented ... hell i dont even remember exactly
> >                      what range the input needed to had for the output to be
> >                      correct)
> > ff_sqrt*            (iam unsure if not maybe we should have 16.16 fixed point
> >                      output, so i dont want people to depend on it yet)
> > MASK_ABS
> > COPY3_IF_LT         (probably these could be removed entirely, needs benchmark
> >                      for the spots where its used, Note dont forget -mcpu
> >                      /-march)
> > 
> > should stay unavailable to the outside world
> 
> Does the attached patch fit your ideas of how it should be done?

yes, also when you commit it, you should svn copy common.h internal.h


> Some things might be disputable, like putting ff_get_fourcc into
> internal.h, but it uses assert, and I wouldn't want that so much in a public

well, then remove that assert?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is