[Ffmpeg-devel] Re: [PATCH] GXF muxer

[Michael Niedermayer]

Hi

On Tue, Jul 18, 2006 at 01:43:47PM +0200, Baptiste Coudurier wrote:
> Hi
> 
> Michael Niedermayer wrote:
> > [...]
> > 
> > except these ive no objections, feel free to commit it ...
> > 
> 
> Ok I changed it as you suggested. I added dts code. Are dts correct for
> audio packets ? Im afraid the division will not be exact.

i dont know the gxf spec so i cant comment on what is correct for gxf
but at least for anything but 16bit raw audio it looks very wrong


> 
> I also notice first packet has dts -1 when encoding to mpeg2. Am I doing
> something wrong as usual ?

no, thats a feature (or bug), whichever way you want to see it


btw, please commit this, and send patches relative to what will then be
in svn as that would simplify reviewing ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is