[Ffmpeg-devel] Re: [PATCH] Intel Mac MMX/SSE2 support

[Diego Biurrun]

On Thu, Jul 20, 2006 at 11:11:22AM +0200, Guillaume POIRIER wrote:
> 
> On 7/20/06, Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> >On Thu, Jul 20, 2006 at 01:16:48PM +1000, Nigel Pearson wrote:
> >>       Guillaume's reworked patch seems fairly tidy to me.
> 
> The patch wasn't mine. It was provided by Nicolas Plourde.

IIRC, Nicolas' patch was better than its predecessors, but it was never
properly reviewed.

> >> Apart from one missing line of context at the end,
> >> it applies cleanly to SVN r5799, and with the configure
> >> workaround (no memalign), builds and almost works.
> >>
> >> (make test fails ...
> >
> >1. nothing almost working will be applied, it has to be fully working

I think this should be clarified a bit.  Intel Mac support currently
has several problems.  Not all of them need to be solved for a patch to
get applied.  Patches should solve the issues they address in a clean
way, though.

Diego