[Ffmpeg-devel] [PATCH] avoid useless memcpy with src==dst (valgrind complains)

Måns Rullgård mru
Sun Jul 23 10:50:50 CEST 2006


Reimar D?ffinger said:
> Hello,
> On Sun, Jul 09, 2006 at 12:05:16AM +0200, Reimar D?ffinger wrote:
>> maybe this is cosmetics (not sure of the speed effects, but I doubt the
>> matter here), but I prefer to have less warnings with valgrind (this is
>> a memcpy here since buf and last point to structs).

Simple assignment can be faster than memcpy and is clearer.

> Since I use valgrind a lot I intend to apply. If you don't like it
> please shout.

No reason not to be valgrind clean.

-- 
M?ns Rullg?rd
mru at inprovide.com




More information about the ffmpeg-devel mailing list