[Ffmpeg-devel] Re: [PATCH] MXF demuxer improvements

[Michael Niedermayer]

Hi

On Fri, Jul 28, 2006 at 07:27:20PM +0200, Baptiste Coudurier wrote:
[...]
> > [...]
> >>  /* SMPTE RP224 http://www.smpte-ra.org/mdd/index.html */
> >> -static const CodecTag mxf_sound_essence_labels[] = {
> >> -    { CODEC_ID_PCM_S16LE, 0x01000000 },/* Uncompressed Sound Coding */
> >> -    { CODEC_ID_PCM_S16LE, 0x017F0000 },/* Uncompressed Sound Coding */
> >> -    { CODEC_ID_PCM_S16BE, 0x017E0000 },/* Uncompressed Sound Coding Big Endian*/
> >> -    { CODEC_ID_PCM_ALAW,  0x02030101 },
> >> -    { CODEC_ID_AC3,       0x02030201 },
> >> -  //{ CODEC_ID_MP1,       0x02030104 },
> >> -    { CODEC_ID_MP2,       0x02030105 },/* MP2 or MP3 */
> >> -  //{ CODEC_ID_MP2,       0x02030106 },/* MPEG-2 Layer 1 */
> >> -  //{ CODEC_ID_???,       0x0203010C },/* Dolby E */
> >> -  //{ CODEC_ID_???,       0x02030301 },/* MPEG-2 AAC */
> >> -    { 0, 0 },
> >> -};
> > 
> > some of these codec ids seem to have dissapeared in the new code, i assume
> > they never worked, or why where they removed?
> > 
> 
> Well, finally I thought that poluting the demuxer with ids not used was
> not a nice solution, I'll just add uls I encouter in files one after
> one, is that solution worse ?

hmm, if theres no file on earth which uses them then of course theres no
point in adding them, if OTOH there is a file which uses one then that
file will not be supported ... and not everyone who has such a file
will write a bugreport  ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is