[Ffmpeg-devel] Two ASF related bugs and fixes

[Guillaume POIRIER]

Hi,

On 4/19/06, Michael Niedermayer <michaelni at gmx.at> wrote:
> Hi
>
> On Tue, Apr 18, 2006 at 05:11:06PM +0300, emild at cs.technion.ac.il wrote:
> > Hello,
> >
> > I have found two bugs related to ffmpeg's ASF file format.
> >
> > 1) The first bug has to do with the ASF writer. The problem is caused by the
> > fact that the size of the padding is not adjusted to include the size of
> > the padding length field. This causes the last byte of the payload to be
> > overwritten with zeroes before it is written to disk, thus yielding an invalid
> > bitstream.
> > mplayer and even ffmpeg complain when such streams are passed to them.
>
> i think asf_packet_size_left should be set correctly in put_frame()
> not be changed later because one field length has been forgotten ...
>
> also note that the regression test checksums if they change must be
> included in the patch


The fixed version of this patch has never been sent, so I guess this
patch is just dropped.



> > 2) The second bug has to do with the ASF file format reader. The reader ignores
> > the size of the ASF data object and keeps on reading even beyond it. Therefore
> > if the ASF file includes an index object at its end, the reader will treat the
> > index like data, but of course will fail since it thinks that the data is
> > corrupted. When reading an asf file with an index object, ffmpeg will complain
> > at the end of the file that it read an invalid header.
>
> patch ok i think (after remocing tabs and such of coarse)

I fixed the tabs and trailling spaces issues and committed this patch.

Guillaume

-- 
Conditional branch execution in SIMD vector processors are patented! :
http://www.freepatentsonline.com/4435758.html
All ASM SIMD code writers are outlaws!