[Ffmpeg-devel] [PATCH] vp6 in flv

[Benjamin Larsson]

Aurelien Jacobs wrote:

>
>That's right. Here is my version of this patch.
>
>Aurel
>
Does this enable vp6 flv playback in mplayer ?

>
>
>Index: libavcodec/avcodec.h
>===================================================================
>--- libavcodec/avcodec.h       (revision 5457)
>+++ libavcodec/avcodec.h       (working copy)
>@@ -63,6 +63,7 @@
>     CODEC_ID_H264,
>     CODEC_ID_INDEO3,
>     CODEC_ID_VP3,
>+    CODEC_ID_VP6,
>     CODEC_ID_THEORA,
>     CODEC_ID_ASV1,
>     CODEC_ID_ASV2,
>
This breaks binary compatibility. Add the codec at the end.

>Index: libavformat/flvdec.c
>===================================================================
>--- libavformat/flvdec.c       (revision 5457)
>+++ libavformat/flvdec.c       (working copy)
>@@ -184,6 +184,9 @@
>             switch(flags & 0xF){
>             case 2: st->codec->codec_id = CODEC_ID_FLV1; break;
>             case 3: st->codec->codec_id = CODEC_ID_FLASHSV; break;
>+            case 4: st->codec->codec_id = CODEC_ID_VP6;
>+                    get_byte(&s->pb); /* width and height adjustment */
>+                    size--; break;
>             default:
>                     av_log(s, AV_LOG_INFO, "Unsupported video codec (%x)\n", flags & 0xf);
>                 st->codec->codec_tag= flags & 0xF;
>
>
This looks sort of ok. But I think we should output that vp6 is an unsupported codec instead of nothing. If this patch do enable vp6 playback under mplayer it's ok.

MvH
Benjamin Larsson