[Ffmpeg-devel] Re: [PATCH] VP6 to flv muxing

[Michael Niedermayer]

Hi

On Thu, Jun 08, 2006 at 08:05:45PM +0200, Baptiste Coudurier wrote:
> M?ns Rullg?rd wrote:
> > Benjamin Larsson <banan at student.ltu.se> writes:
> > 
> >> Hi,
> >>
> >> Michael Niedermayer wrote:
> >>
> >>> if you add a byte during flv muxing, shouldnt you remove i during flv
> >>> demuxing?
> >>>
> >>> [...]
> >>>
> >>>  
> >>>
> >> That could be done or define a new codec id and let that decoder handle
> >> the extra byte.
> > 
> > I don't like that idea at all.  If one container requires some extra
> > stuff, then it's the responsibility of the demuxer to deal with it.
> > It's unfortunate when this happens, but there is no other sensible way
> > to handle it.
> > 
> 
> I fully agree with Mans, in the same idea, can I remove
> CODEC_ID_MPEG4AAC in favor of CODEC_ID_AAC ? 

yes, i think so ... of coarse only if nothing breaks ...


> But that will break binary
> compatibility I guess.

just put the code under
#if LIBAVCODEC_VERSION_INT > / < ...

so the change will happen next time we break compatibility

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is