[Ffmpeg-devel] [PATCH] support for vorbis language in native ogg demuxer

[Måns Rullgård]

Rich Felker <dalias at aerifal.cx> writes:

> On Wed, Jun 21, 2006 at 12:49:28AM +0200, Nico Sabbi wrote:
>> $Subject says everything, but there's to notice that (as for everything
>> that has to deal with stuff done by xiph) there are hideous shortcomings:
>> - the language is identified in a non-standardized way, so it's
>> longer than 3 characters and in a mixed-case format (e.g. English,
>> Japanese, etc.)
>> - I didn't strtolower() them because afaik this depends on the charset used
>
> Charset is ASCII [A-Za-z]. Just or each byte with 0x20, IMO. :)

Vorbis comments are utf8.  Furthermore, there is no official field for
language.  Thus we must assume that a language field, if present,
might contain anything.

Is there anything about Ogg that doesn't suck?

-- 
M?ns Rullg?rd
mru at inprovide.com