[Ffmpeg-devel] [PATCH] GUID is defined in the Windows API (DirectShow)

[Steve Lhomme]

M?ns Rullg?rd wrote:
> Reimar D?ffinger said:
>> Hi,
>> On Tue, Feb 28, 2006 at 03:33:07PM -1000, Steve Lhomme wrote:
>>> ...so this patch renames libavformat's GUID to wGUID. Feel free to
>>> rename it to something better if you need.
>> Can you explain why? I guess asf.h does not include directx.h, and
>> directx.h sure doesn't include our asf.h, so do you include both at some
>> place?
> 
> Nobody should be including asf.h.  It's not part of the lavf external API.

We have some DirectShow code in DrFFMPEG. Mostly in C++, that's why I 
don't even bother trying to share it here. And this code is in a "dshow" 
directory located at the same level as libavcodec or libavformat. Plus 
we had to move the "public" headers of FFMPEG in a separate dir to fit 
our SVN hierarchy and help CruiseControl working.

I know you don't need to care about that. But at least you know that 
when people use your library they are limited by the possibilities. Just 
because you think "fixing the compiler" is the easy way to do. I guess 
there's no compiler specific code in FFMPEG and whenever you hit a 
problem, you fix the compiler...

/me pissed