[Ffmpeg-devel] Re: [PATCH] DVCPRO50 support

[Baptiste COUDURIER]

Hi

Roman Shaposhnick wrote:
> On Wed, Mar 01, 2006 at 08:08:56PM -0500, Dan Maas wrote:
> 
>>Hi Roman - Here is the big patch for DVCPRO50 support. Please look it
>>over and get back to me with any comments. 
> 
> 
> Hi Dan -- thanks a lot for submitting it. I'll try to take a look
> at it today.
> 
> 
>>This adds support for both NTSC and PAL with 4:2:2 sampling at 50
>>Mbps, according to SMPTE 314M. The 50 Mbps mode is turned on when you
>>compress or decompress 4:2:2 video (PIX_FMT_YUV422P). Otherwise it
>>operates at 25 Mbps just like before.
> 
> 
>   Seems like a reasonable choice.

Sorry to disturb the discussion, but why not adding a new video codec ?
CODEC_ID_DVCPRO50 ? IMHO It would simpler to handle wrapping in
different containers (thinking about MOV), which must be different.

I tested the patch and it perfectly plays in Quicktime Player and Final
Cut, in DV file format. Talking about MOV, setting fourcc to 'dv5p'
makes it working.

Just noticed one thing. When you probe the stream, pix_fmt is not set
correctly, displays yuv420p while obvioulsy pix_fmt is yuv422p.

> [...]
> P.S. Would applying this patch faster increase our chances of getting your 
> DVCPRO HD work as the next patch ? ;-) 

I will test it as soon as the patch is posted. Thanks for the great job Dan.

Best regards,

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312