[Ffmpeg-devel] [patch] Darwin shared object support

[Michael Niedermayer]

Hi

On Mon, Mar 06, 2006 at 11:13:48AM +0100, Diego Biurrun wrote:
> On Tue, Feb 21, 2006 at 10:25:32PM +0100, Michael Niedermayer wrote:
> > Hi
> > 
> > On Tue, Feb 21, 2006 at 12:53:34PM +0100, Sam Hocevar wrote:
> > > On Thu, Feb 16, 2006, Sam Hocevar wrote:
> > > >    Hello, this little patch adds the proper mangling information for
> > > > symbols in OS X Mach-O shared objects.
> > > 
> > >    Hello? Is there anything terribly wrong with my patches? I haven't
> > > got any feedback yet.
> > 
> > they look ok, can be applied if someone checks they work ...
> 
> Did your OK extend to his other patches?

probably not, but what other patches?


> 
> I just applied the mangling one.

hmm, you applied

@@ -13,6 +13,8 @@
    (defined(__OpenBSD__) && !defined(__ELF__))
 #if defined(ARCH_X86_64) && defined(PIC)
 #define MANGLE(a) "_" #a"(%%rip)"
+#elif defined(CONFIG_DARWIN)
+#define MANGLE(a) "_" #a
 #else
 #define MANGLE(a) "_" #a
 #endif

but the patch contained:

@@ -19,6 +19,8 @@
 #else
 #if defined(ARCH_X86_64) && defined(PIC)
 #define MANGLE(a) #a"(%%rip)"
+#elif defined(CONFIG_DARWIN)
+#define MANGLE(a) "_" #a
 #else
 #define MANGLE(a) #a
 #endif

and correct would have been

#if defined(__CYGWIN__) || defined(__MINGW32__) || defined(__OS2__) || \
-   (defined(__OpenBSD__) && !defined(__ELF__))
+   (defined(__OpenBSD__) && !defined(__ELF__)) || defined(CONFIG_DARWIN)

so diego and sam and myself, please read the code before oking or applying

[...]

-- 
Michael