[Ffmpeg-devel] [PATCH] h264 *_pixels16_l2_altivec

[Luca Barbato]

Romain Dolbeau wrote:
> Michael Niedermayer wrote:
> 
>> if there are no objections (Romain Dolbeau?) then this can be applied
>> assuming you did test it for binary identical h.264 decoding
> 
> I think the fact that src_stride2 is hardwired to 16
> should be mentioned above the functions, should it
> be called from someplace that doesn't know about
> the restriction.

The previous code assumed the same, so I just removed the define and
hardwired it there.

> 
> Doesn't H264 requires image_stride % 16 == 0 ? Because
> if it can be assumed src_stride1 % 16 == 0, then the
> vec_lvsl can be moved out of the loop.

Not sure I check this evening

> 
> (I don't think that src1/src2/dst are always properly
> aligned ? that could solve the performance problem)
> 

sadly they are all unaligned.

lu

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero