[Ffmpeg-devel] Re: [PATCH] h264 muxing in mp4

[Baptiste COUDURIER]

Hi

Michael Niedermayer wrote:
> [...]
> 
> i would change avc_find_startcode so it outputs end instead of NULL if
> nothing is found, that way the following code could be simplified like:

Done.

> [...]
> 
> somehow my feeling tells me that
> while(!*(nal_start++));
> would be better but maybe its too hackisch (or even wrong ...)

Done.

> this isnt needed, code which extract global headers from the bitstream
> is in the AVParser and is activated by -vglobal 1 on the cmd line

You were right.
Here is a clean patch. I guess that's a really good start.

Now, we still need to fix pts and dts from AVI stream, and from RAW
bytestream and H264 in mp4 is complete.

Second patch is for fixing 'edts', 'elst' atom when track contains B
frames, needed for Quicktime Player and Final Cut Pro. It has to be
tested for PSP.

It will update and add regression tests for H264 when it will be commited.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: movenc_h264.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060310/7b399a22/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: movenc_b_frames_fix.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060310/7b399a22/attachment.asc>