[Ffmpeg-devel] [PATCH] Snow mmx+sse2 asm optimizations

[Oded Shimon]

On Fri, Mar 10, 2006 at 07:04:30PM +0100, Michael Niedermayer wrote:
> Hi
> 
> On Fri, Mar 10, 2006 at 07:41:36PM +0200, Oded Shimon wrote:
> [...]
> > longer expensive in snow... I merged the 2 patches here... md5sum checks 
> 
> rejected, i will not review a >100k patch, split it and send a seperate
> patch or wait until that huge optimizatio patch has been reviewed and applied

OK, I'll wait. Could you look over Robert's patch then?... It (should be) 
production ready...

> > out. I was worried about odd resolutions, but it seems Snow has stopped 
> > supporting any resolution not divisable by 8...
> 
> this is defintly not intended, any resolution which is a multiple of 2
> should work
> allthough we might at some point decide to internally round it up to
> a multiple of X to simplify everything but that needs PSNR/bitrate tests
> with several videos at several qualities (=it needs a volunteer to do these
> tests)

http://www1.mplayerhq.hu/cgi-bin/cvsweb.cgi/ffmpeg/libavcodec/snow.c.diff?r1=1.76&r2=1.77&cvsroot=FFMpeg

mencoder: snow.c:2421: pred_block: Assertion `b_w == b_h || 2*b_w == b_h || b_w == 2*b_h' failed.

I'm not sure why/how, but that is the assert fail.

- ods15