[Ffmpeg-devel] Re: [PATCH] h264 muxing in mp4

[Michael Niedermayer]

Hi

On Sun, Mar 12, 2006 at 02:46:38PM +0100, Erik Slagter wrote:
> On Sat, 2006-03-11 at 14:44 +0100, Michael Niedermayer wrote:
> > > > +        while(!*(nal_start++));
> > >           ^^^^^^^^^^^^^^^^^^^^^^^
> > > > +        nal_end = avc_find_startcode(nal_start, end);
> > > > +        put_be32(&pb, nal_end - nal_start);
> > > 
> > > Isn't this a bit dangerous?
> > 
> > IMHO no, nal_start < end should gurantee that there is a 00 00 01 there
> > so the while wont runaway
> 
> Even is if the bitstream for some reason is completely bogus?

learn c, read the code and say where it is supposed to fail OR send a
bugrepert with a problematic stream attached, i already said the code
is correct in my oppinion

[...]

-- 
Michael