[Ffmpeg-devel] Re: [PATCH] MOV pcm sample size fix

[Michael Niedermayer]

Hi

On Sun, Mar 12, 2006 at 08:04:49PM +0100, Baptiste COUDURIER wrote:
> Michael Niedermayer wrote:
> > Hi
> > 
> > On Sun, Mar 12, 2006 at 04:51:39PM +0100, Baptiste COUDURIER wrote:
> > 
> >>Hi,
> >>
> >>Here is a patch to fix sample size for uncompressed sound, handling it
> >>in a generic way in stsz parsing, and removing the special check in
> >>read_packet.
> >>
> >>Is that acceptable and correct ?
> > 
> > 
> > iam not sure, personally i would limit the code to the case where
> > sample_size==1 but maybe thats not a good idea ...
> > 
> 
> Well, I thought that too, but after all, if sample size is set wrongly
> to 2 or something else, it will be failing, I don't really know...

well, it might be set to a multiple of the correct value, which is not
that incorrect and i dont know if changing the sample_size has any
sideeffects, mov.c is big and messy ...


> 
> Let's set it that way and see if it breaks many samples (none of mine atm) ?

ok

[...]
-- 
Michael