[Ffmpeg-devel] [PATCH] Snow mmx+sse2 asm optimizations

[Robert Edele]

On Mon, 2006-03-13 at 03:54 +0100, Luca Barbato wrote:
> Robert Edele wrote:
> [...]
> 
> 
> @@ -1557,8 +1470,8 @@
>  STOP_TIMER("vertical_compose97i")}}
> 
>  {START_TIMER
> -        if(y-1<(unsigned)height) horizontal_compose97i(b0, width);
> -        if(y+0<(unsigned)height) horizontal_compose97i(b1, width);
> +        if(y-1<(unsigned)height) ff_snow_horizontal_compose97i(b0, width);
> +        if(y+0<(unsigned)height) ff_snow_horizontal_compose97i(b1, width);
> 
> 
> Why not dsputilize it too?
> 
A fair question. The reasoning is that only the encoder, which is not
sliced, uses this function. However, this should not be important for
horizontal and vertical compose so long as stride is aligned. The
regtest might very well not catch this error, so is stride in horizontal
and vertical compose 16-byte aligned?

Robert Edele