[Ffmpeg-devel] [PATCH] DVB AC-3 support in mpegts.c

[Andy Brown]

>> Could we as a first step please add the currently hardcoded values to
>> mpegts.h, such as in the following patch?
>>
>> Regards,
>> Wolfram.
>>
>> --- ffmpeg/libavformat/mpegts.h	Mon Jan 16 10:00:09 2006
>> +++ ffmpeg-wg/libavformat/mpegts.h	Wed Mar 15 11:21:25 2006
>> @@ -33,7 +33,11 @@
>>  #define SDT_TID   0x42
>>   /* descriptor ids */
>> +#define DVB_LANGUAGE_DESCID         0x0a
>> +#define DVB_TELETEXT_DESCID         0x56
>>  #define DVB_SUBT_DESCID             0x59
>> +#define DVB_AC3_DESCID              0x6a
>> +#define DVB_ENHANCED_AC3_DESCID     0x7a
>>   #define STREAM_TYPE_VIDEO_MPEG1     0x01
>>  #define STREAM_TYPE_VIDEO_MPEG2     0x02
>> @@ -49,6 +53,7 @@
>>  #define STREAM_TYPE_AUDIO_DTS       0x8a
>>   #define STREAM_TYPE_SUBTITLE_DVB    0x100
>> +#define STREAM_TYPE_TELETEXT        0x101
>>   unsigned int mpegts_crc32(const uint8_t *data, int len);
>>  extern AVOutputFormat mpegts_mux;
>> l

The patch to mpegts.h is a much better solution to my hardcoded values in
mpegts.c.


>
> there are also: 0x7B for  DTS and 0x7C for AAC
>

I included 0x7A, but I'm honestly not sure what the difference is between AC-3
and Enhanced AC-3, more importantly, does it require a different codec? 
  As far
as DTS and AAC, I'm not sure but the organization of the PMT might be a little
different than for AC-3.  It clearly states that the stream type of the AC-3
should be listed as private (0x06) but it doesn't make such a claim for 
DTS and
AAC.  I'll need to look into TS 102 114 (for DTS) and ISO/IEC 14496-3 (AAC) to
see if it is explained in there.

Andy