[Ffmpeg-devel] Re: [PATCH] framehook change

[Baptiste COUDURIER]

Michael Niedermayer wrote:
> Hi
> 
> On Mon, Mar 20, 2006 at 10:37:48AM +0100, Baptiste COUDURIER wrote:
> 
>>Baptiste COUDURIER wrote:
>>
>>>Hi,
>>>
>>>This patch changes a bit the vhook framework, passing AVCodecContext
>>>argument directly. That way it enables vhook's modules to use
>>>informations from decoder.
>>>
>>>Any suggestion ? Objection ?
>>>
>>
>>Is it ok to apply that ? Is there any maintainer of vhook ? May I apply
>>then ?
> 
> 
> why not work on libavfilter?

That will be next step. Im waiting for Luca's patch.

> patch is IMO not acceptable, width&height might not match the ones from
> the codec, a filter might change w/h, ok vhook doesnt seem to allow that
> ATM but this change moves us even farther away from it
> 

Well, width and height comes from dec, dec->width, dec->height, I just
pass the whole dec as arg, yes they could be changed in vhook, they
probably will in libavfilter, no ?

That means passing one arg instead of 3.
I can just change avctx to (const *) if you prefer.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312