[Ffmpeg-devel] Re: [PATCH] qt-faststart > 4gb files compliant

[Rich Felker]

On Tue, Mar 21, 2006 at 01:19:59AM +0100, Baptiste COUDURIER wrote:
> Mike Melanson wrote:
> > Baptiste COUDURIER wrote:
> > 
> >> Hi,
> >>
> >> This patch makes qt-faststart 64 bit file offsets compliant.
> >>
> >> Patch to Makefile is to use CFLAGS while compiling qt-faststart, to set
> >> _FILE_OFFSET_BITS to 64, define _LARGEFILE_SOURCE
> > 
> > 
> >     Seriously? Hmm, just looked at the man pages. I never knew ftello()
> > and fseeko() existed. Are the functions really that widespread? Do they
> > exist on Windows or Mac OS X (not that I care; just curious).
> > 
> 
> Is that acceptable ?
> 
> -- 
> Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
> SMARTJOG S.A.                                    http://www.smartjog.com
> Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
> Phone: +33 1 49966312

> Index: qt-faststart.c
> ===================================================================
> RCS file: /cvsroot/ffmpeg/ffmpeg/qt-faststart.c,v
> retrieving revision 1.6
> diff -u -p -r1.6 qt-faststart.c
> --- qt-faststart.c	16 Mar 2006 23:57:40 -0000	1.6
> +++ qt-faststart.c	21 Mar 2006 00:10:41 -0000
> @@ -24,6 +24,13 @@
>  #include <stdlib.h>
>  #include <inttypes.h>
>  
> +#include "config.h"
> +
> +#ifdef CONFIG_WIN32
> +#    define fseeko fseeko64
> +#    define ftello ftello64
> +#endif

Probably should be mingw-only. I suspect cygwin correctly defines
fseeko and ftello and may possibly already have #defined them.

Rich