[Ffmpeg-devel] [PATCH] cygwin, link error

[Diego Biurrun]

On Wed, Mar 29, 2006 at 11:23:02AM +0100, M?ns Rullg?rd wrote:
> 
> Diego Biurrun said:
> > On Tue, Mar 21, 2006 at 01:15:50PM +0100, Marcus Engene wrote:
> >>
> >> --- Makefile.org	2006-03-21 14:02:07.343750000 +0100
> >> +++ Makefile	2006-03-21 14:02:27.343750000 +0100
> >> @@ -66,7 +66,7 @@
> >>  OBJS+= audio.o
> >>  endif
> >>
> >> -EXTRALIBS += -L../libavutil -lavutil$(BUILDSUF) -lavcodec$(BUILDSUF)
> >> -L../libavcodec
> >> +EXTRALIBS := -L../libavutil -lavutil$(BUILDSUF) -lavcodec$(BUILDSUF)
> >> -L../libavcodec $(EXTRALIBS)
> >
> > I don't particularly like it, but I don't know a better solution.  Mans?
> 
> The only other solution I can think of is to split EXTRALIBS into two
> variables, one that is set only from configure and one that is set in
> the makefiles.  I'm not convinced this is much cleaner though.

I'm thinking of using this construct everywhere:

EXTRALIBS := -Lfoo -bar $(EXTRALIBS)

That would at least make it consistent everywhere.

> Do as you see fit, you're the makefile maintainer.

Nah, I'll happily share the duty with you :)

Diego