[Ffmpeg-devel] Re: [BUG] ALAC decoder

[matthieu castet]

Hi,

Baptiste COUDURIER wrote:

> ------------------------------------------------------------------------
> 
> Index: libavcodec/alac.c
> ===================================================================
> RCS file: /cvsroot/ffmpeg/ffmpeg/libavcodec/alac.c,v
> retrieving revision 1.10
> diff -u -p -r1.10 alac.c
> --- libavcodec/alac.c	21 Feb 2006 00:03:10 -0000	1.10
> +++ libavcodec/alac.c	8 May 2006 12:56:40 -0000
> @@ -602,7 +602,7 @@ static int alac_decode_frame(AVCodecCont
>              int i;
>              for (i = 0; i < outputsamples; i++) {
>                  int16_t sample = alac->outputsamples_buffer_a[i];
> -                sample = be2me_16(sample);
> +                sample = le2me_16(sample);
>                  ((int16_t*)outbuffer)[i * alac->numchannels] = sample;
>              }
>              break;
> 
> 
Hum before the patch it was :
for ppc sample = sample;
gor x86 sample = bswap_32(sample);

Now with your patch, it is :
for x86 sample = sample;
gor ppc sample = bswap_32(sample);

I bet the correct patch is to remove the le2me_16.

Matthieu