[Ffmpeg-devel] Increasing Audio Buffer Size

[Michael Niedermayer]

Hi

On Tue, May 09, 2006 at 03:10:46PM -0400, Cyril Zorin wrote:
[...]
> >
> >
> >>takes, insofar that at a certain point an "Audio Frame" is just a  
> >>free-area
> >>of crap that the decoder can fill in, without organizing it by  
> >>"channel" or
> >>whatever.
> >
> >for video its organized by color components and lines, so your free  
> >form
> >crap is not analogous
> 
> I meant "free form" in that I specify how I'll organize my color  
> data. Take the mental leap there before

well, and that then either doesnt apply to video or it applies to audio
too, depending on how you define it exactly


> you start calling things "crap", in order to impress... who?

you called it crap first (just read what you wrote above), i just 
refered to it by the same word, sorry that your own terminology offends you


> 
> >
> >
> >>
> >>Also, if it were up to me, I'd leave the AVFrame struct well alone  
> >>and make
> >>an "AFrame" or otherwise something for "audio frame". I wouldn't  
> >>want to
> >>clutter AVFrame any more.
> >
> >thats certainly a possibility, if its better i dont know, what i do  
> >know
> >is it will be more work and possibly more complicated code ...
> >we would need AVFrame, AFrame, VFrame later 2 would be "subclasses"
> >of AVFrames (= their first fields match the ones from AVFrame)
> 
> Subclasses? What for? 

to avoid code duplication


> Shit. 

http://en.wikipedia.org/wiki/Hypocrit


> If you think that breaking things down  
> and therefore separating concerns is
> making code "complicated", then I think I lost the debate before I  
> got into it.

thers a difference between seperating independant parts and duplicating things
both audio and video frames need a storeage area, timestamps, some quality
field for encoding, PSNR, keyframe/nonkeyframe flag, ...

they should be in a struct common to both audio and video -> the suggested
AVFrame/AFrame/VFrame
going this way is more work, and as i said possibly more complicated in the
end, maybe its not, you can of course send a patch (or melanson can choose
to implement things with AVFrame/AFrame/VFrame in the first place if he 
prefers)

[...]
-- 
Michael

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is