[Ffmpeg-devel] [BUG] vorbis decoder

[Benjamin Larsson]

When running valgrind on x86 I get this:

==19675== Invalid read of size 4
==19675==    at 0x8283E55: vorbis_parse_setup_hdr_modes (bitstream.h:605)
==19675==    by 0x82840A0: vorbis_parse_setup_hdr (vorbis.c:841)
==19675==    by 0x82847AB: vorbis_decode_init (vorbis.c:986)
==19675==    by 0x80ABA44: avcodec_open (utils.c:874)
==19675==    by 0x80589E5: av_encode (ffmpeg.c:1789)
==19675==    by 0x805C420: main (ffmpeg.c:4178)
==19675==  Address 0x1BAAF43B is 4347 bytes inside a block of size 4349
alloc'd
==19675==    at 0x1B90506F: realloc (vg_replace_malloc.c:196)
==19675==    by 0x80ACF2C: av_realloc (mem.c:116)
==19675==    by 0x80938D8: vorbis_header (oggparsevorbis.c:153)
==19675==    by 0x8092A22: ogg_packet (ogg2.c:384)
==19675==    by 0x809332A: ogg_read_header (ogg2.c:416)
==19675==    by 0x805E13C: av_open_input_stream (utils.c:498)
==19675==    by 0x805E39A: av_open_input_file (utils.c:611)
==19675==    by 0x8059C07: opt_input_file (ffmpeg.c:2799)
==19675==    by 0x805DAA8: parse_options (cmdutils.c:99)
==19675==    by 0x805C381: main (ffmpeg.c:4164)
Press [q] to stop encoding
==19675==
==19675== Use of uninitialised value of size 4
==19675==    at 0x8286699: vorbis_parse_audio_packet (vorbis.c:1638)
==19675==    by 0x82867A4: vorbis_decode_frame (vorbis.c:1674)
==19675==    by 0x80AC792: avcodec_decode_audio (utils.c:973)
==19675==    by 0x805700C: output_packet (ffmpeg.c:1134)
==19675==    by 0x80592AE: av_encode (ffmpeg.c:1969)
==19675==    by 0x805C420: main (ffmpeg.c:4178)

And the offending line is this:
ret[k]=saved[saved_start+i]+buf[i]*swin[i]+BIAS;

MvH
Benjamin Larsson

-- 
"incorrect information" is an oxymoron. Information is, by definition, factual, correct.