[Ffmpeg-devel] [PATCH] fix two warnings in libavformat/rm.c

[Dominik 'Rathann' Mierzejewski]

On Saturday, 13 May 2006 at 23:58, M?ns Rullg?rd wrote:
> Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org> writes:
> 
> > This fixes:
> > rm.c:561: warning: ?return? with a value, in function returning void
> > rm.c:573: warning: ?return? with a value, in function returning void
> > rm.c:586: warning: ?return? with a value, in function returning void
> 
> How is this function actually called?  Returning a value certainly
> makes sense, but is it being checked?

It's not, but maybe it'd make sense to check it. It's called around lines
617 and 711.

> > and:
> > rm.c: In function ?rm_read_packet?:
> > rm.c:957: warning: enumeration value ?CODEC_ID_NONE? not handled in switch
> 
> These are silenced by -Wno-switch, which is default in ffmpeg.  I'd
> prefer using that to cluttering perfectly correct code.

Oh, cool. I forgot about that one.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan