[Ffmpeg-devel] [PATCH] AVImageFormat kill

[Baptiste Coudurier]

Michael Niedermayer wrote:
> Hi
> 
> On Thu, Nov 02, 2006 at 09:40:08PM +0100, Baptiste Coudurier wrote:
>> Hi
>>
>> Here is the patch that kills AVImageFormat, and removes image format in
>> favor of image2. Can be applied as soon as gif encoder patch is applied.
>> Michael ?
> 
> this must increase the major version number of libavformat
> 

ok

> why dont you remove gifdec.c completely? what is in it that 
> libavcodec/gifdec.c doesnt support?

gifdec.c still supports animated gif, decoder does not support it yet.
I admit it must be supported, but Im sick of that deprecated AVImageFormat.

Also gifdec.c will probe sucessfully animated gif. Need to move that
probe to img2.c I think, or let it in gifdec.c, and set codec_id correctly.

> 
>> Index: libavformat/avformat.h
>> ===================================================================
>> --- libavformat/avformat.h	(revision 6872)
>> +++ libavformat/avformat.h	(working copy)
>> @@ -122,7 +122,7 @@
>>      int width;
>>      int height;
>>      enum PixelFormat pix_fmt;
>> -    struct AVImageFormat *image_format;
>> +    void *place_holder;
> 
> senseless, compatibility is already broken by removing the image formats
> 
> [...]

ok

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312