[Ffmpeg-devel] PUT_UTF8 & asf format enhancement

[Michael Niedermayer]

Hi

On Sun, Nov 05, 2006 at 05:14:32PM +0800, Zuxy Meng wrote:
> Hi,
> 
> 2006/11/5, Diego Biurrun <diego at biurrun.de>:
> >On Sun, Nov 05, 2006 at 04:56:13PM +0800, Zuxy Meng wrote:
> >>
> >> 1. Add a PUT_UTF8 macro to common.h; code borrowed from
> >> libavcodec/flacenc.c.
> >
> >Code duplication is generally not acceptable, but I cannot find that
> >macro in libavcodec/flacenc.c ...
> 
> It's in write_utf8(). Once previous patches get applied it can
> replaced by PUT_UTF8 too and hence code duplication is avoided.

or move the flacenc.c utf8 code into common.h first and then make
asf use it, the way you do it there will be indeed some code 
duplication until flacenc.c is fixed, so iam fine with your patch
after you send another patch which changes flacenc.c to use the code
too, or if you send a single patch doing both or similar

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is