[Ffmpeg-devel] 4XM audio codec_tag

[Måns Rullgård]

Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:

> Hi
>
> Diego Biurrun wrote:
>> Hi,
>> 
>> libavformat/4xm.c sets st->codec->codec_tag = 1 for 4XM audio.  This
>> seems wrong, codec_id 1 would be PCM audio.  ffplay seems to be able to
>> cope with this, but MPlayer cannot.
>> 
>> So what codec_id could/should be used in this case?  4XMA seems to work
>> fine, any other suggestions?  Does it have to be a TwoCC?
>> 
>
> set codec_id to what it is supposed to be CODEC_ID_ADPCM_4XM, and don't

That's already being done.

> set codec_tag. Format that does not support fourcc should not set
> codec_tag, anyway.

Indeed.

> If mplayer cannot dectect CODEC_ID_ADPCM_4XM, use a conversation table
> between CODEC_ID_ADPCM_4XM and whatever mplayer wants to use as internal
> fourcc.
>
> This is becoming more and more problematic...

It's only a problem because mplayer is really an AVI player with
support for other formats shoe-horned on as an afterthought.

-- 
M?ns Rullg?rd
mru at inprovide.com