[Ffmpeg-devel] [RFC] Fraps v2 support

[Kostya]

On Sun, Nov 05, 2006 at 04:24:09PM +0100, Michael Niedermayer wrote:
[...] 
> 
> > Thus, is the sum does not overflow (check is done with int64_t sum, so when
> > when something will appear in bits > 31 it will be catched), all nodes' counts
> > are <= sum so overflow won't happen.
> 
> i indeed have misread your code somehow ... sorry
> 
> but your code still doesnt look safe, as you add signed int32, so large and
> small counts can cancell each other out and then intermediats in the final
> calculation can overflow

I'll add check for count < 0.

> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> In the past you could go to a library and read, borrow or copy any book
> Today you'd get arrested for mere telling someone where the library is
>