[Ffmpeg-devel] [PATCH] Matroska keep extradata for some codec

[Michael Niedermayer]

Hi

On Mon, Nov 06, 2006 at 07:23:34PM +0100, Steve Lhomme wrote:
> Hi,
> 
> As the title suggests... The extradata are used by some codec. AAC is 
> not handled because we don't support it cleanly enough for now.

this patch confuses me a little, currently we have

            void *extradata = NULL;
            int extradata_size = 0;

then, no matches for extradata except

            if(extradata){
                st->codec->extradata = extradata;
                st->codec->extradata_size = extradata_size;
            } else if(track->codec_priv && track->codec_priv_size > 0){
                st->codec->extradata = av_malloc(track->codec_priv_size);
                if(st->codec->extradata == NULL)
                    return AVERROR_NOMEM;
                st->codec->extradata_size = track->codec_priv_size;
                memcpy(st->codec->extradata, track->codec_priv,
                       track->codec_priv_size);
            }

so what does your code change? it seems to change nothing, as it looks
like we already set extradata


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is