[Ffmpeg-devel] [PATCH] Networking with MingW

[Michael Niedermayer]

Hi

On Tue, Nov 07, 2006 at 03:17:01AM +0100, Diego Biurrun wrote:
> On Mon, Nov 06, 2006 at 06:25:25PM -0600, Michael A. Kohn wrote:
> > 
> > On Tue, 7 Nov 2006, Fran?ois Revol wrote:
> > 
> > >And I will do this if you don't mind, but don't mess up with something
> > >you can't test.
> > >I'll remove the net_server support code to simplify stuff, everyone
> > >uses the illegal-BONE-beta or Zeta or Haiku now anyway.
> > 
> > You're right.  I can't test this on BEOS.  This is a new version of the 
> > patch with the gxf.c changes removed.  Can you please test this patch with 
> > BEOS and someone accept this patch?
> 
> You misunderstand.  You have no business messing with BeOS stuff, thus
> your patch should not touch it.  In any case it mixes two different
> things: MinGW networking and BeOS cleanup.  This has to be separated.
> 
> Patch in its current form rejected.

additionally, things like


+#if defined(__BEOS__) || defined(__MINGW32__) || defined(__INNOTEK_LIBC__)
+typedef int socklen_t;
+#endif

should rather be

#ifndef HAVE_SOCKLEN_T
typedef int socklen_t;
#endif

with HAVE_SOCKLEN_T set by configure
or even typedef in config.h


these huge messy prerocessor checks all over the source are ugly and make the
code unreadable

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is