[Ffmpeg-devel] trunk liba52 using non compatible assembly with x86_64

[Michael Niedermayer]

Hi

On Tue, Nov 07, 2006 at 01:29:53PM +0100, Diego Biurrun wrote:
> On Tue, Nov 07, 2006 at 11:43:11AM +0100, Michael Niedermayer wrote:
> > 
> > On Mon, Nov 06, 2006 at 11:39:16PM +0100, Diego Biurrun wrote:
> > > On Mon, Nov 06, 2006 at 10:39:43PM +0100, Guillaume POIRIER wrote:
> > > > 
> > > > On 11/6/06, Diego Biurrun <diego at biurrun.de> wrote:
> > > > >On Mon, Nov 06, 2006 at 07:48:16PM +0100, Christian Casteyde wrote:
> > > > >> ffmpeg doesn't compile with liba52 enabled on the trunk SVN version,
> > > > >> apparently due to assembly code in resample_mmx.c that is not compatible
> > > > >
> > > > >Time to remove the internal liba52 then?  Nobody is going to fix it
> > > > >anyway...
> > > > 
> > > > How come MPlayer's liba52 doesn't blow out on x86-64? Isn't MPlayer's
> > > > 1:1 ffmpeg's liba52?
> > > 
> > > No, it's newer and patched.
> > 
> > mplayers liba52 is older just grep -i for copyright and look at the years
> 
> Can't be, MPlayer uses 0.7.4, which is the last version.  Either
> somebody forgot to update the MPlayer copyright years or the ones in
> FFmpeg got bumped for whatever reason.

mplayer/liba52/a52.h: * Copyright (C) 2000-2002 Michel Lespinasse <walken at zoy.org>
libavcodec/liba52/a52.h: * Copyright (C) 2000-2003 Michel Lespinasse <walken at zoy.org>

http://liba52.cvs.sourceforge.net/liba52/a52dec/include/a52.h?view=markup
* Copyright (C) 2000-2003 Michel Lespinasse <walken at zoy.org>

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is