[Ffmpeg-devel] [PATCH] get rid of CODEC_ID_MPEG4AAC after next major version bump

[Baptiste Coudurier]

Michael Niedermayer wrote:
> Hi
> 
> On Thu, Nov 09, 2006 at 12:23:10AM +0100, Baptiste Coudurier wrote:
> [...]
>> Index: libavformat/avidec.c
>> ===================================================================
>> --- libavformat/avidec.c	(revision 6947)
>> +++ libavformat/avidec.c	(working copy)
>> @@ -443,6 +443,8 @@
>>                      /* special case time: To support Xan DPCM, hardcode
>>                       * the format if Xxan is the video codec */
>>                      st->need_parsing = 1;
>> +                    if (st->codec->codec_id == CODEC_ID_AAC && st->codec->extradata_size)
>> +                        st->need_parsing = 0; /* do not parse since header is in extradata */
> 
> why? what bad happens if st->need_parsing = 1 ?
> 

Here faad is just getting mad, and throws a lot of:
[aac @ 0x85ce1f8]faac: frame decoding failed: Invalid number of channels

mplayer with lavf demuxer:
FAAD: Failed to decode frame: Invalid number of channels
FAAD: Failed to decode frame: Invalid number of channels
FAAD: Failed to decode frame: Invalid number of channels

sample tested was A-codecs/AAC/file.avi.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312