[Ffmpeg-devel] [RFC] Some Progressive JPEG support

[Michael Niedermayer]

Hi

On Mon, Nov 06, 2006 at 08:18:45AM +0200, Kostya wrote:
> Here is result of my efforts to add Progressive JPEG support.
> It is not complete (as it ignores refinement planes but that
> is not possible to implement without keeping all DCT coefficients).
> But progressive jpegs should be decoded correctly.
> 
> I won't have time to work on it and will be happy if somebody
> will finish it.

ok, ill review none the less ...
maybe ill fix the things i found in my own review :)
maybe someone else will do before me ...


> +/* decode block and dequantize - progressive JPEG version */
> +static int decode_block_progressive(MJpegDecodeContext *s, DCTELEM *block,
> +                        int component, int dc_index, int ac_index, int16_t *quant_matrix,
> +                        int ss, int se, int Ah, int Al, int *EOBRUN)
> +{

should be doxygen comment


[...]
> +static int mjpeg_decode_scan_progressive(MJpegDecodeContext *s, int nb_components, int ss, int se, int Ah, int Al){

this could maybe be merged with mjpeg_decode_scan() they look pretty similar

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is