[Ffmpeg-devel] a little optim for a SSE version of H263_LOOP_FILTER

[Guillaume Poirier]

Hi,

skal wrote:
>   Hi everybody, sorry for the delay

Having your mail held for moderation for 2 days surely didn't help ;-)


>>Message du 06/11/06 14:48
>>Objet : Re: [Ffmpeg-devel] a little optim for a SSE version of H263_LOOP_FILTER
> 
> [...]
> 
>>>>Please send patch, I'll try to benchmark the speed change.
>>>>
>>>>Note that movq is very slow on P4, so any code that removes
>>>>mov(q|dqu|..) provides an interesting speed-up.
>>>>
>>>>
>>>>
>>>>> Well, this is just for the fun of it, since the speed-up
>>>>> (if any) might not be worth a special version...
>>>>
>>>>Once I have a patch to play with, I can benchmark it on P4, PM, and K8... :)
>>>
>>>   sure, attached is the diff (test only!)
>>
>>Mmm.. I thought it would be slightly more complicated since you said
>>"+maybe a little re-org of the loop (mm3 is gone)."
>>
>>Ok, I've tried your patch.Regression tests pass, however, I have
>>trouble testing your patch behond that. I lack a sample with proper
>>inloop filter it seems.
>>I've tried this sample
>>http://samples.mplayerhq.hu/V-codecs/h263/100374.mov and a couple of
>>others, whithout any luck...
>>Maybe I'm not benchmarking the relevant parts of the inloop filter
>>(see attachemnt to see what I was benchmarking)?
>>Or could you provide a sample to run my benches?
> 
> 
>    You can try:
> 
> ftp://ftp.mplayerhq.hu/MPlayer/samples/FLV/flv1.1/sheep_MM_FLV1.1.flv
> 
>    which is using h263's in-loop deblocking iirc.


Mmm... maybe I'm very unlucky or dumb (or both), but it doesn't look
like there's an inloop filter in this one, as the benchmark code is
not getting executed. I've tried to decode with this command:

./ffmpeg/ffmpeg_g -v 9 -i sheep_MM_FLV1.1.flv -y -f rawvideo /dev/null

which I know works fine as it's the command I used to benchmark cabac
code.

the patch bench_h263.diff that I sent earlier has the spot where I put
the START/STOP macros...



>    And yes, h263 isn't that uncommon if you think of it as
>    flv1 ~= h263 = YouTube
> 
>    ahem..

True that, but since comedy central videos got pulled out, I don't
have much use for YouTube these days ;-)

Guillaume