[Ffmpeg-devel] Getting rid of inlining failure warnings

[Panagiotis Issaris]

Hi,

On Thu, 2006-11-09 at 08:18 -0800, Steve DeLaney wrote:
>[...]
> Anyway thanks for investigating this problem. I'd like to better understand
> how these changes are propagated.
> 
> I see this went out as a patch.  But will these changes be pushed into the
> SVN trunk?
>  I would like to svn update to pick up these changes. Or should we use the
> patch for now?
Not in the current state. As Michael pointed out, I was wrong in
assuming that the patch could not have a performance impact -under the
constraint that every system would have had the same inlining warnings-.
The warning regarding GCC's failing to inline it is call specific, so
removing the inline specifier could alter GCC's decision in other
places, where the same function would have been called but no warning
was given before as inlining succeeded.

With friendly regards,
Takis