[Ffmpeg-devel] [PATCH] Handle "A_AAC" in matroska codec IDs

[Steve Lhomme]

Baptiste Coudurier wrote:
> Hi
> 
> Steve Lhomme wrote:
>> Hi,
>>
>> As the title suggests.
>> You can find a sample at this URL:
>> http://www.matroska.org/~robux4/drdivx/samples/ticket-a_aac.mkv
>>
>> Steve
>>
>> [...]
>> @@ -2245,7 +2245,7 @@
>>  
>>              }
>>  
>> -            if (codec_id==CODEC_ID_AAC) {
>> +            else if (codec_id == CODEC_ID_AAC && !track->codec_priv_size) {
>>                  MatroskaAudioTrack *audiotrack = (MatroskaAudioTrack *) track;
>>                  int profile = matroska_aac_profile(track->codec_id);
>>                  int sri = matroska_aac_sri(audiotrack->internal_samplerate);
>>
> 
> Is that hunk needed ? File seems to play fine without and only the first
> hunk.

Yes it does work without. Except there's no need to regenerate the 
extradata if they are already set in the file.

Steve