[Ffmpeg-devel] [PATCH] imc.c log2() removal

Dominik 'Rathann' Mierzejewski dominik
Sat Nov 11 01:36:14 CET 2006


On Friday, 10 November 2006 at 20:38, Benjamin Larsson wrote:
[...]
> @@ -255,7 +252,7 @@
>                  level -=16;
>  
>              tmp  *= imc_exp_tab[15 + level];
> -            tmp2 += q->flcf2 * level;
> +            tmp2 += 0.83048 * level;

IMHO add a comment where those values come from.

>              flcoeffs1[i] = tmp;
>              flcoeffs2[i] = tmp2;
>          }
> @@ -273,7 +270,7 @@
>          flcoeffs1[i] = 0;
>          if(levlCoeffBuf[i] < 16) {
>              flcoeffs1[i] = imc_exp_tab2[levlCoeffBuf[i]] * old_floor[i];
> -            flcoeffs2[i] = (levlCoeffBuf[i]-7) * q->flcf2 + flcoeffs2[i];
> +            flcoeffs2[i] = (levlCoeffBuf[i]-7) * 0.83048 + flcoeffs2[i];

Same here.

>          } else {
>              flcoeffs1[i] = old_floor[i];
>          }
> Index: MAINTAINERS
> ===================================================================
> --- MAINTAINERS	(revision 6934)
> +++ MAINTAINERS	(working copy)
> @@ -127,6 +127,7 @@
>    h263*                                 Michael Niedermayer
>    huffyuv.c                             Michael Niedermayer
>    idcinvideo.c                          Mike Melanson
> +  imc*                                  Benjamin Larsson


This is unrelated...

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan




More information about the ffmpeg-devel mailing list