[Ffmpeg-devel] [PATCH] add some static keywords

Aurelien Jacobs aurel
Sun Nov 12 00:26:55 CET 2006


On Sat, 11 Nov 2006 21:21:01 +0000
M?ns Rullg?rd <mru at inprovide.com> wrote:

> I did a search for extern symbols that were not actually used outside
> the file that defined them.  The most obvious ones I've already made
> static.  Here's a patch for the remainder.  It obviously builds on my
> machine.  However I'm not certain that some of these perhaps were
> intentionally extern.
> 
> Please comment.
> 
> Index: libavcodec/vp6data.h
> ===================================================================
> --- libavcodec/vp6data.h	(revision 6974)
> +++ libavcodec/vp6data.h	(working copy)
> @@ -275,7 +275,7 @@
>      {  -2,  18, 124, -12  } },
>  };
>  
> -const vp56_tree_t vp6_pcr_tree[] = {
> +static const vp56_tree_t vp6_pcr_tree[] = {

Right. This one is a mistake and should indeed be static.

Aurel




More information about the ffmpeg-devel mailing list